Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1109393012: Allow use of deferred type-literals in non-constant contexts. (Closed)

Created:
5 years, 7 months ago by sigurdm
Modified:
5 years, 7 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Allow use of deferred type-literals in non-constant contexts. BUG= dartbug.com/22893 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=45459

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -96 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 1 7 chunks +52 lines, -37 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 5 chunks +37 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 10 chunks +64 lines, -42 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart View 2 chunks +9 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sigurdm
5 years, 7 months ago (2015-04-30 08:08:37 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/1109393012/diff/1/pkg/compiler/lib/src/compile_time_constants.dart File pkg/compiler/lib/src/compile_time_constants.dart (right): https://codereview.chromium.org/1109393012/diff/1/pkg/compiler/lib/src/compile_time_constants.dart#newcode52 pkg/compiler/lib/src/compile_time_constants.dart:52: {bool enforceConst: true}); Document [enforceConst]. https://codereview.chromium.org/1109393012/diff/1/pkg/compiler/lib/src/deferred_load.dart File pkg/compiler/lib/src/deferred_load.dart ...
5 years, 7 months ago (2015-04-30 09:15:04 UTC) #3
sigurdm
https://codereview.chromium.org/1109393012/diff/1/pkg/compiler/lib/src/compile_time_constants.dart File pkg/compiler/lib/src/compile_time_constants.dart (right): https://codereview.chromium.org/1109393012/diff/1/pkg/compiler/lib/src/compile_time_constants.dart#newcode52 pkg/compiler/lib/src/compile_time_constants.dart:52: {bool enforceConst: true}); On 2015/04/30 09:15:03, Johnni Winther wrote: ...
5 years, 7 months ago (2015-04-30 11:21:44 UTC) #5
sigurdm
5 years, 7 months ago (2015-04-30 11:39:15 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as 45459 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698