Implement Function.apply in dart2js.

Implement Function.apply in dart2js.
Committed: https://code.google.com/p/dart/source/detail?r=13409

[kasperl, 2012-10-09 08:27:22]

Quick comment:

http://codereview.chromium.org/11093015/diff/2001/tests/corelib/corelib.status
File tests/corelib/corelib.status (right):

http://codereview.chromium.org/11093015/diff/2001/tests/corelib/corelib.statu...
tests/corelib/corelib.status:12: apply2_test: Fail # Bug 5670
dart2dart?

[ngeoffray, 2012-10-09 08:41:24]

http://codereview.chromium.org/11093015/diff/2001/tests/corelib/corelib.status
File tests/corelib/corelib.status (right):

http://codereview.chromium.org/11093015/diff/2001/tests/corelib/corelib.statu...
tests/corelib/corelib.status:12: apply2_test: Fail # Bug 5670
On 2012/10/09 08:27:22, kasperl wrote:
> dart2dart?

Good catch. Done.

[kasperl, 2012-10-09 11:35:17]

LGTM with comments:

http://codereview.chromium.org/11093015/diff/6002/lib/compiler/implementation...
File lib/compiler/implementation/enqueue.dart (right):

http://codereview.chromium.org/11093015/diff/6002/lib/compiler/implementation...
lib/compiler/implementation/enqueue.dart:106: if (element ==
compiler.functionApplyMethod) {
else if?

http://codereview.chromium.org/11093015/diff/6002/lib/compiler/implementation...
File lib/compiler/implementation/js_backend/emitter.dart (right):

http://codereview.chromium.org/11093015/diff/6002/lib/compiler/implementation...
lib/compiler/implementation/js_backend/emitter.dart:498: // Keep a cache of
which stubs have already been generated, to
Where did the cache move? I guess the comment needs updating.

http://codereview.chromium.org/11093015/diff/6002/lib/compiler/implementation...
lib/compiler/implementation/js_backend/emitter.dart:530: Set<Selector> newSet =
new Set<Selector>.from(selectors);
Wouldn't it be simpler to collect the new selectors in another set and add them
in one step using addAll at the end? That way you don't have to copy the ever
growing set of all the selectors.

http://codereview.chromium.org/11093015/diff/6002/lib/compiler/implementation...
File lib/compiler/implementation/lib/js_helper.dart (right):

http://codereview.chromium.org/11093015/diff/6002/lib/compiler/implementation...
lib/compiler/implementation/lib/js_helper.dart:634: // Dart string sort and JS
String sort. To avoid needing the Dart
JS String -> JS string

[ngeoffray, 2012-10-09 11:56:58]

Thanks Kasper

http://codereview.chromium.org/11093015/diff/6002/lib/compiler/implementation...
File lib/compiler/implementation/enqueue.dart (right):

http://codereview.chromium.org/11093015/diff/6002/lib/compiler/implementation...
lib/compiler/implementation/enqueue.dart:106: if (element ==
compiler.functionApplyMethod) {
On 2012/10/09 11:35:18, kasperl wrote:
> else if?

Done.

http://codereview.chromium.org/11093015/diff/6002/lib/compiler/implementation...
File lib/compiler/implementation/js_backend/emitter.dart (right):

http://codereview.chromium.org/11093015/diff/6002/lib/compiler/implementation...
lib/compiler/implementation/js_backend/emitter.dart:498: // Keep a cache of
which stubs have already been generated, to
On 2012/10/09 11:35:18, kasperl wrote:
> Where did the cache move? I guess the comment needs updating.

Done.

http://codereview.chromium.org/11093015/diff/6002/lib/compiler/implementation...
lib/compiler/implementation/js_backend/emitter.dart:530: Set<Selector> newSet =
new Set<Selector>.from(selectors);
On 2012/10/09 11:35:18, kasperl wrote:
> Wouldn't it be simpler to collect the new selectors in another set and add
them
> in one step using addAll at the end? That way you don't have to copy the ever
> growing set of all the selectors.

Good point. Done.

http://codereview.chromium.org/11093015/diff/6002/lib/compiler/implementation...
File lib/compiler/implementation/lib/js_helper.dart (right):

http://codereview.chromium.org/11093015/diff/6002/lib/compiler/implementation...
lib/compiler/implementation/lib/js_helper.dart:634: // Dart string sort and JS
String sort. To avoid needing the Dart
On 2012/10/09 11:35:18, kasperl wrote:
> JS String -> JS string

Done.

[ahe, 2012-10-09 12:12:26]

http://codereview.chromium.org/11093015/diff/4002/lib/compiler/implementation...
File lib/compiler/implementation/compiler.dart (right):

http://codereview.chromium.org/11093015/diff/4002/lib/compiler/implementation...
lib/compiler/implementation/compiler.dart:390:
functionClass.ensureResolved(this);
I think this is problematic.

http://codereview.chromium.org/11093015/diff/4002/lib/compiler/implementation...
File lib/compiler/implementation/lib/core_patch.dart (right):

http://codereview.chromium.org/11093015/diff/4002/lib/compiler/implementation...
lib/compiler/implementation/lib/core_patch.dart:37: return
Primitives.applyFunction(
If you make this function top-level, then you can use that function without
resolving any classes.