Issue 11092099: Guard against buffer overflow in the x64 disassembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11092099: Guard against buffer overflow in the x64 disassembler. (Closed)

Created:
8 years, 2 months ago by Kevin Millikin (Google)

Modified:
8 years, 2 months ago

Reviewers:
erikcorry, Erik Corry

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Guard against buffer overflow in the x64 disassembler. BUG= Committed: https://code.google.com/p/dart/source/detail?r=13598

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	runtime/vm/disassembler_x64.cc	View		2 chunks	+7 lines, -5 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/11092099/diff/1/runtime/vm/disassembler_x64.cc File runtime/vm/disassembler_x64.cc (right): http://codereview.chromium.org/11092099/diff/1/runtime/vm/disassembler_x64.cc#newcode431 runtime/vm/disassembler_x64.cc:431: if (available <= 1) return; // Space for ...

8 years, 2 months ago (2012-10-12 08:06:27 UTC) #2

Kevin Millikin (Google)

8 years, 2 months ago (2012-10-12 08:12:03 UTC) #3

Thanks for the review.

http://codereview.chromium.org/11092099/diff/1/runtime/vm/disassembler_x64.cc
File runtime/vm/disassembler_x64.cc (right):

http://codereview.chromium.org/11092099/diff/1/runtime/vm/disassembler_x64.cc...
runtime/vm/disassembler_x64.cc:431: if (available <= 1) return;  // Space for
'\0' terminator.
On 2012/10/12 08:06:27, Erik Corry wrote:
> Perhaps assert that the null char is there.

Done.

Expand Messages | Collapse Messages