Complete support for type variables in new expressions.

Complete support for type variables in new expressions.

Committed: https://code.google.com/p/dart/source/detail?r=13475

[floitsch, 2012-10-10 13:04:44]

LGTM.

http://codereview.chromium.org/11092046/diff/2001/lib/compiler/implementation...
File lib/compiler/implementation/ssa/builder.dart (right):

http://codereview.chromium.org/11092046/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/ssa/builder.dart:2740: /** Helper to create an
instruction to get the value of a type variable. */
.. instruction that gets ...

http://codereview.chromium.org/11092046/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/ssa/builder.dart:2756: localsHandler.readThis());
indentation.

http://codereview.chromium.org/11092046/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/ssa/builder.dart:2775: * this type, where type
variables are substituted by their runtime value.
Add example output (of the template).

http://codereview.chromium.org/11092046/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/ssa/builder.dart:2794: isFirstVariable = false;
move isFirstVariable up into the if.

http://codereview.chromium.org/11092046/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/ssa/builder.dart:2799: } else {
add explanation what it must be. for example.
assert(type is XYType);

[karlklose, 2012-10-10 13:44:45]

Thanks, Florian.

http://codereview.chromium.org/11092046/diff/2001/lib/compiler/implementation...
File lib/compiler/implementation/ssa/builder.dart (right):

http://codereview.chromium.org/11092046/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/ssa/builder.dart:2740: /** Helper to create an
instruction to get the value of a type variable. */
On 2012/10/10 13:04:44, floitsch wrote:
> .. instruction that gets ...

Done.

http://codereview.chromium.org/11092046/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/ssa/builder.dart:2756: localsHandler.readThis());
On 2012/10/10 13:04:44, floitsch wrote:
> indentation.

Done.

http://codereview.chromium.org/11092046/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/ssa/builder.dart:2775: * this type, where type
variables are substituted by their runtime value.
On 2012/10/10 13:04:44, floitsch wrote:
> Add example output (of the template).

Done.

http://codereview.chromium.org/11092046/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/ssa/builder.dart:2794: isFirstVariable = false;
Done, moved into else branch.

http://codereview.chromium.org/11092046/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/ssa/builder.dart:2799: } else {
On 2012/10/10 13:04:44, floitsch wrote:
> add explanation what it must be. for example.
> assert(type is XYType);

Done.

[ngeoffray, 2012-10-15 12:05:20]

DBC

https://codereview.chromium.org/11092046/diff/4001/lib/compiler/implementatio...
File lib/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/11092046/diff/4001/lib/compiler/implementatio...
lib/compiler/implementation/ssa/builder.dart:2786: void buildTypeString(DartType
type, {isInQuotes: false}) {
Could you move the non-ssa parts of this helper in the rti library?