Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 11092024: Add VERSION file to the checkout. (Closed)

Created:
8 years, 2 months ago by ricow1
Modified:
8 years, 2 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add VERSION file to the checkout. Committed: https://code.google.com/p/dart/source/detail?r=13461

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
A tools/VERSION View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
8 years, 2 months ago (2012-10-09 17:44:29 UTC) #1
Ivan Posva
Can we also move the VERSION file under tools to avoid polluting the top-level directory? ...
8 years, 2 months ago (2012-10-10 05:04:07 UTC) #2
ricow1
8 years, 2 months ago (2012-10-10 06:29:11 UTC) #3
Moved the file and dropped the =

https://codereview.chromium.org/11092024/diff/1/VERSION
File VERSION (right):

https://codereview.chromium.org/11092024/diff/1/VERSION#newcode2
VERSION:2: MINOR=1
On 2012/10/10 05:04:07, Ivan Posva wrote:
> Please drop the '=' and replace it with a ' '.

Done.

Powered by Google App Engine
This is Rietveld 408576698