Fix Timers in isolates in dart2js.

Fix Timers in isolates in dart2js.

BUG=http://dartbug.com/5734

Committed: https://code.google.com/p/dart/source/detail?r=13428

[vsm, 2012-10-09 00:14:33]

https://chromiumcodereview.appspot.com/11092016/diff/4001/tests/isolate/timer...
File tests/isolate/timer_isolate_test.dart (right):

https://chromiumcodereview.appspot.com/11092016/diff/4001/tests/isolate/timer...
tests/isolate/timer_isolate_test.dart:20: replyPort.send("timer_fired");
This seems brittle as I don't think there is a guarantee that replyPort is set
before you get here.

Perhaps it'd be better to move the new Timer up into the receive above - i.e.,
only fire the Timer once you have the replyPort.

[justinfagnani, 2012-10-09 00:18:01]

https://codereview.chromium.org/11092016/diff/4001/tests/isolate/timer_isolat...
File tests/isolate/timer_isolate_test.dart (right):

https://codereview.chromium.org/11092016/diff/4001/tests/isolate/timer_isolat...
tests/isolate/timer_isolate_test.dart:20: replyPort.send("timer_fired");
On 2012/10/09 00:14:33, vsm wrote:
> This seems brittle as I don't think there is a guarantee that replyPort is set
> before you get here.
> 
> Perhaps it'd be better to move the new Timer up into the receive above - i.e.,
> only fire the Timer once you have the replyPort.

Done.

[vsm, 2012-10-09 03:32:46]

lgtm

[dgrove, 2012-10-09 05:16:33]

(please cc compiler-dev for changes to lib/compiler)