Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 11091012: Clean up TODOs and comments in Intl (Closed)

Created:
8 years, 2 months ago by Alan Knight
Modified:
8 years, 2 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Clean up TODOs and comments in Intl Committed: https://code.google.com/p/dart/source/detail?r=13383

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -34 lines) Patch
M pkg/intl/lib/date_format.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/intl/lib/intl.dart View 1 2 chunks +34 lines, -2 lines 0 comments Download
M pkg/intl/lib/message_lookup_local.dart View 1 chunk +1 line, -26 lines 0 comments Download
M pkg/intl/tool/generate_locale_data_files.dart View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alan Knight
Clean up some TODOs that have been fixed in Intl, and move the DartDoc comment ...
8 years, 2 months ago (2012-10-08 23:02:07 UTC) #1
Emily Fortuna
https://codereview.chromium.org/11091012/diff/1/pkg/intl/lib/intl.dart File pkg/intl/lib/intl.dart (right): https://codereview.chromium.org/11091012/diff/1/pkg/intl/lib/intl.dart#newcode32 pkg/intl/lib/intl.dart:32: * related tasks. An Intl instance can be created ...
8 years, 2 months ago (2012-10-08 23:16:58 UTC) #2
Alan Knight
https://codereview.chromium.org/11091012/diff/1/pkg/intl/lib/intl.dart File pkg/intl/lib/intl.dart (right): https://codereview.chromium.org/11091012/diff/1/pkg/intl/lib/intl.dart#newcode32 pkg/intl/lib/intl.dart:32: * related tasks. An Intl instance can be created ...
8 years, 2 months ago (2012-10-08 23:22:50 UTC) #3
Emily Fortuna
8 years, 2 months ago (2012-10-08 23:25:18 UTC) #4
sweet! lgtm

Powered by Google App Engine
This is Rietveld 408576698