Issue 11090046: Add a dart library and a dart script for creating version numbers.

Issue 11090046: Add a dart library and a dart script for creating version numbers. (Closed)

Created:
8 years, 2 months ago by ricow1

Modified:
8 years, 2 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add a dart library and a dart script for creating version numbers. Committed: https://code.google.com/p/dart/source/detail?r=13469

Patch Set 4 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+189 lines, -0 lines)			Patch
	A	tools/testing/dart/version.dart	View	1 2 3	1 chunk	+172 lines, -0 lines	0 comments	Download
	A	tools/version.dart	View	1 2	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

https://codereview.chromium.org/11090046/diff/4001/tools/testing/dart/version.dart File tools/testing/dart/version.dart (right): https://codereview.chromium.org/11090046/diff/4001/tools/testing/dart/version.dart#newcode22 tools/testing/dart/version.dart:22: #library("version"); You should be able to use the new ...

8 years, 2 months ago (2012-10-10 12:21:05 UTC) #2

ricow1

8 years, 2 months ago (2012-10-10 12:32:39 UTC) #4

https://codereview.chromium.org/11090046/diff/4001/tools/testing/dart/version...
File tools/testing/dart/version.dart (right):

https://codereview.chromium.org/11090046/diff/4001/tools/testing/dart/version...
tools/testing/dart/version.dart:22: #library("version");
On 2012/10/10 12:21:05, kasperl wrote:
> You should be able to use the new library syntax.
> 
>   library version;
>   import "dart:io";

Done.

https://codereview.chromium.org/11090046/diff/4001/tools/testing/dart/version...
tools/testing/dart/version.dart:82: "contain on of {MAJOR, MINOR, BUILD,
PATCH}");
On 2012/10/10 12:21:05, kasperl wrote:
> on -> one

Done.

https://codereview.chromium.org/11090046/diff/4001/tools/testing/dart/version...
tools/testing/dart/version.dart:107: if (repositoryType !=
RepositoryType.UNKNOWN) {
On 2012/10/10 12:21:05, kasperl wrote:
> Maybe invert this to avoid all the nesting (early return).

Done.

https://codereview.chromium.org/11090046/diff/4001/tools/testing/dart/version...
tools/testing/dart/version.dart:115: // If anything goes wrong parsing the
revision number we simply return 0
On 2012/10/10 12:21:05, kasperl wrote:
> Terminate comment with .

Done.

https://codereview.chromium.org/11090046/diff/4001/tools/testing/dart/version...
tools/testing/dart/version.dart:132: // If we can't get the username simple
return "" (e.g. on windows)
On 2012/10/10 12:21:05, kasperl wrote:
> Terminate comment with .

Done.

https://codereview.chromium.org/11090046/diff/4001/tools/testing/dart/version...
tools/testing/dart/version.dart:149: String _versionFile;
On 2012/10/10 12:21:05, kasperl wrote:
> We usually put fields at the top of class definitions. Maybe rename
_versionFile
> to _versionFileName to make it clear that it isn't some kind of file
> abstraction.

Done.

Expand Messages | Collapse Messages