- Allow to pre-filter before calling the FindObjectVisitor.

- Allow to pre-filter before calling the FindObjectVisitor.

R=asiva@google.com, johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31408

[Cutch, 2013-12-30 22:03:55]

lgtm after fixing the next_obj_addr issue.

[siva, 2013-12-30 22:15:12]

LGTM with one comment

https://codereview.chromium.org/110883016/diff/1/runtime/vm/pages.cc
File runtime/vm/pages.cc (right):

https://codereview.chromium.org/110883016/diff/1/runtime/vm/pages.cc#newcode89
runtime/vm/pages.cc:89: ((filter_addr >= obj_addr) && (filter_addr < end_addr)))
{
Instead of a filter_addr method in the visitor interface wouldn't it be better
to have a method:

virtual bool VisitRange(uword start_addr, uword end_addr);

which allows the visitor to decide whether this range needs to
be visited or not.

and the code here could be:

if (visitor->VisitRange(obj_addr, end_addr)) {
  ....
  ....
  if (visitor->VisitRange(obj_addr, end_addr) &&
      raw_obj->FindObject(visitor)) {
    return raw_obj;
  }
}

https://codereview.chromium.org/110883016/diff/1/runtime/vm/pages.cc#newcode94
runtime/vm/pages.cc:94: ((filter_addr >= obj_addr) && (filter_addr < end_addr)))
&&
next_obj_addr ?

[Ivan Posva, 2013-12-31 00:26:58]

https://codereview.chromium.org/110883016/diff/1/runtime/vm/pages.cc
File runtime/vm/pages.cc (right):

https://codereview.chromium.org/110883016/diff/1/runtime/vm/pages.cc#newcode89
runtime/vm/pages.cc:89: ((filter_addr >= obj_addr) && (filter_addr < end_addr)))
{
Redone as discussed.

On 2013/12/30 22:15:12, siva wrote:
> Instead of a filter_addr method in the visitor interface wouldn't it be better
> to have a method:
> 
> virtual bool VisitRange(uword start_addr, uword end_addr);
> 
> which allows the visitor to decide whether this range needs to
> be visited or not.
> 
> and the code here could be:
> 
> if (visitor->VisitRange(obj_addr, end_addr)) {
>   ....
>   ....
>   if (visitor->VisitRange(obj_addr, end_addr) &&
>       raw_obj->FindObject(visitor)) {
>     return raw_obj;
>   }
> }

https://codereview.chromium.org/110883016/diff/1/runtime/vm/pages.cc#newcode94
runtime/vm/pages.cc:94: ((filter_addr >= obj_addr) && (filter_addr < end_addr)))
&&
On 2013/12/30 22:15:12, siva wrote:
> next_obj_addr ?

Done.

[Ivan Posva, 2013-12-31 00:27:20]

Committed patchset #2 manually as r31408 (presubmit successful).