Issue 11088084: Revert r13569 "Automagically start up selenium server for Safari." Seems to be

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11088084: Revert r13569 "Automagically start up selenium server for Safari." Seems to be (Closed)

Created:
8 years, 2 months ago by Emily Fortuna

Modified:
8 years, 2 months ago

Reviewers:
Alan Knight, Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Revert r13569 "Automagically start up selenium server for Safari." Seems to be causing widespread browser failure. Will investigate. Committed: https://code.google.com/p/dart/source/detail?r=13578

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tools/testing/dart/test_options.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	tools/testing/dart/test_runner.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Alan Knight

It's not clear to me what this is trying to accomplish, but if it's just ...

8 years, 2 months ago (2012-10-11 20:03:00 UTC) #2

LGTM :-(