Issue 11088059: Lower ~/ priority from WARNING to INFO

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11088059: Lower ~/ priority from WARNING to INFO (Closed)

Created:
8 years, 2 months ago by scheglov

Modified:
8 years, 2 months ago

Reviewers:
devoncarew

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Lower ~/ priority from WARNING to INFO R=devoncarew@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=13499

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

devoncarew

8 years, 2 months ago (2012-10-10 20:43:20 UTC) #2

lgtm

Thanks for taking a look at this Konstantin! I think we should have a talk when
Brians back about auditing Dart code in general, and having a warning category
for audits. This is valuable information to the user, but we need to be careful
about how we present it.

Expand Messages | Collapse Messages