Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11088003: Fix warnings in dart2js. (Closed)

Created:
8 years, 2 months ago by ahe
Modified:
8 years, 2 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, Anton Muhin
Visibility:
Public.

Description

Fix warnings in dart2js. Committed: https://code.google.com/p/dart/source/detail?r=13353

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix long line #

Messages

Total messages: 3 (0 generated)
ahe
8 years, 2 months ago (2012-10-08 13:09:28 UTC) #1
karlklose
LGTM, thank you! https://codereview.chromium.org/11088003/diff/1/dart/lib/compiler/implementation/scanner/array_based_scanner.dart File dart/lib/compiler/implementation/scanner/array_based_scanner.dart (right): https://codereview.chromium.org/11088003/diff/1/dart/lib/compiler/implementation/scanner/array_based_scanner.dart#newcode5 dart/lib/compiler/implementation/scanner/array_based_scanner.dart:5: abstract class ArrayBasedScanner<S extends SourceString> extends ...
8 years, 2 months ago (2012-10-08 13:35:36 UTC) #2
ahe
8 years, 2 months ago (2012-10-08 13:38:03 UTC) #3 
https://codereview.chromium.org/11088003/diff/1/dart/lib/compiler/implementat...
File dart/lib/compiler/implementation/scanner/array_based_scanner.dart (right):

https://codereview.chromium.org/11088003/diff/1/dart/lib/compiler/implementat...
dart/lib/compiler/implementation/scanner/array_based_scanner.dart:5: abstract
class ArrayBasedScanner<S extends SourceString> extends AbstractScanner<S> {
On 2012/10/08 13:35:37, karlklose wrote:
> Long line.

Done.

Powered by Google App Engine
This is Rietveld 408576698