Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1108763005: Don't list pkg/third_party when finding packages (Closed)

Created:
5 years, 8 months ago by ricow1
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Don't list pkg/third_party when finding packages R=kevmoo@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45431

Patch Set 1 #

Patch Set 2 : Also don't list in testing script #

Patch Set 3 : remove pkg/third_party/.gitignore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M pkg/pkg.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D pkg/third_party/.gitignore View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
5 years, 8 months ago (2015-04-27 18:41:58 UTC) #1
kevmoo
Also remove pkg/third_party/.gitignore then LGTM
5 years, 8 months ago (2015-04-27 20:09:42 UTC) #2
ricow1
Committed patchset #3 (id:40001) manually as 45431 (presubmit successful).
5 years, 8 months ago (2015-04-27 20:11:50 UTC) #3
ricow1
5 years, 8 months ago (2015-04-27 20:11:55 UTC) #4
Message was sent while issue was closed.
On 2015/04/27 20:09:42, kevmoo wrote:
> Also remove pkg/third_party/.gitignore
> 
> then LGTM

done

Powered by Google App Engine
This is Rietveld 408576698