Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1108763003: fix the bots (Closed)

Created:
5 years, 8 months ago by kevmoo
Modified:
5 years, 8 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
A pkg/third_party/.gitignore View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
kevmoo
5 years, 8 months ago (2015-04-27 14:17:42 UTC) #2
kevmoo
Committed patchset #1 (id:1) manually as 45425 (presubmit successful).
5 years, 8 months ago (2015-04-27 14:18:09 UTC) #3
ricow1
Could you explain what this is fixing?
5 years, 8 months ago (2015-04-27 17:57:38 UTC) #4
kevmoo
On 2015/04/27 17:57:38, ricow1 wrote: > Could you explain what this is fixing? My last ...
5 years, 8 months ago (2015-04-27 18:39:03 UTC) #5
Ivan Posva
On 2015/04/27 18:39:03, kevmoo wrote: > On 2015/04/27 17:57:38, ricow1 wrote: > > Could you ...
5 years, 8 months ago (2015-04-27 19:47:31 UTC) #6
ricow1
5 years, 8 months ago (2015-04-27 19:58:32 UTC) #7
Message was sent while issue was closed.
On 2015/04/27 19:47:31, Ivan Posva wrote:
> On 2015/04/27 18:39:03, kevmoo wrote:
> > On 2015/04/27 17:57:38, ricow1 wrote:
> > > Could you explain what this is fixing?
> > 
> > My last CL remove the final file from pkg/third_party
> > 
> > There is something that calls list_pkg_directories.py looking for
> > pkg/third_party and it blows up since the dir is no longer there.
> > 
> > See
> > 
> >
>
http://build.chromium.org/p/client.dart/builders/vm-mac-debug-ia32-be/builds/...
> 
> Is there a bug tracking this failure and making sure that whatever is
depending
> on the pkg/third_party directory to be around will be updated?
> 
> Thanks,
> -Ivan

I already created:
https://codereview.chromium.org/1108763005

Powered by Google App Engine
This is Rietveld 408576698