Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 110873002: Make pkg/path 1.0.0 and upgrade dependencies appropriately. (Closed)

Created:
7 years ago by nweiz
Modified:
7 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make pkg/path 1.0.0 and upgrade dependencies appropriately. All existing packages that use pkg/path (other than pkg/stack_trace, which has already been updated) are compatible with both the pre-1.0 and post-1.0 path API, so I've marked their version constraints as ">=0.9.0 <2.0.0". I've also incremented their patch versions and I intend to release new versions as soon as this CL lands. R=alanknight@google.com, efortuna@google.com, jmesserly@google.com, rnystrom@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=31005

Patch Set 1 #

Total comments: 4

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M pkg/analyzer/pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/barback/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/csslib/pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/docgen/pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/http/pubspec.yaml View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/http_server/pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/intl/pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/observe/pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/path/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/scheduled_test/pubspec.yaml View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/watcher/pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
nweiz
7 years ago (2013-12-09 23:13:12 UTC) #1
Jennifer Messerly
lgtm
7 years ago (2013-12-09 23:28:19 UTC) #2
Alan Knight
lgtm
7 years ago (2013-12-09 23:30:00 UTC) #3
scheglov
lgtm
7 years ago (2013-12-09 23:30:24 UTC) #4
Emily Fortuna
lgtm
7 years ago (2013-12-09 23:43:05 UTC) #5
Bob Nystrom
https://codereview.chromium.org/110873002/diff/1/pkg/http/pubspec.yaml File pkg/http/pubspec.yaml (right): https://codereview.chromium.org/110873002/diff/1/pkg/http/pubspec.yaml#newcode8 pkg/http/pubspec.yaml:8: stack_trace: ">=0.9.1 <2.0.0" This should be on path, right? ...
7 years ago (2013-12-09 23:48:50 UTC) #6
nweiz
https://codereview.chromium.org/110873002/diff/1/pkg/http/pubspec.yaml File pkg/http/pubspec.yaml (right): https://codereview.chromium.org/110873002/diff/1/pkg/http/pubspec.yaml#newcode8 pkg/http/pubspec.yaml:8: stack_trace: ">=0.9.1 <2.0.0" On 2013/12/09 23:48:51, Bob Nystrom wrote: ...
7 years ago (2013-12-10 00:08:23 UTC) #7
Bob Nystrom
lgtm
7 years ago (2013-12-10 00:16:15 UTC) #8
nweiz
On 2013/12/10 00:16:15, Bob Nystrom wrote: > lgtm I'm submitting this TBR by Søren since ...
7 years ago (2013-12-10 00:22:52 UTC) #9
nweiz
Committed patchset #2 manually as r31005 (presubmit successful).
7 years ago (2013-12-10 00:24:13 UTC) #10
Søren Gjesse
7 years ago (2013-12-10 07:44:39 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698