Issue 11087073: Show and hide combinators supported.

Issue 11087073: Show and hide combinators supported. (Closed)

Created:
8 years, 2 months ago by Johnni Winther

Modified:
8 years, 2 months ago

Reviewers:
ahe, Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Show and hide combinators supported. BUG=3454 Committed: https://code.google.com/p/dart/source/detail?r=13534

Patch Set 2 : Status updated. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -41 lines)			Patch
M	lib/compiler/implementation/library_loader.dart	View	1	11 chunks	+117 lines, -17 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1	2 chunks	+0 lines, -10 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	3 chunks	+2 lines, -12 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM, really nice! https://codereview.chromium.org/11087073/diff/1/lib/compiler/implementation/library_loader.dart File lib/compiler/implementation/library_loader.dart (right): https://codereview.chromium.org/11087073/diff/1/lib/compiler/implementation/library_loader.dart#newcode1 lib/compiler/implementation/library_loader.dart:1: // Copyright (c) 2012, the Dart ...

8 years, 2 months ago (2012-10-11 08:44:24 UTC) #2

Johnni Winther

8 years, 2 months ago (2012-10-11 10:58:24 UTC) #3

https://codereview.chromium.org/11087073/diff/1/lib/compiler/implementation/l...
File lib/compiler/implementation/library_loader.dart (right):

https://codereview.chromium.org/11087073/diff/1/lib/compiler/implementation/l...
lib/compiler/implementation/library_loader.dart:1: // Copyright (c) 2012, the
Dart project authors.  Please see the AUTHORS file
On 2012/10/11 08:44:24, ahe wrote:
> Restore line.

Done.

https://codereview.chromium.org/11087073/diff/1/lib/compiler/implementation/l...
lib/compiler/implementation/library_loader.dart:78: if (show) {
On 2012/10/11 08:44:24, ahe wrote:
> I think the code would be a little bit simpler if you moved this check into
the
> loop.

Done.

https://codereview.chromium.org/11087073/diff/1/tests/co19/co19-dart2js.status
File tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/11087073/diff/1/tests/co19/co19-dart2js.statu...
tests/co19/co19-dart2js.status:720:
Language/13_Libraries_and_Scripts/2_Imports_A01_t39: Fail # Issue 253: Show
combinators are intersections.
On 2012/10/11 08:44:24, ahe wrote:
> Move to line 419 and use comment format "co19 issue 253"

Done.

Expand Messages | Collapse Messages