Issue 11087039: Print out the working directory when git fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11087039: Print out the working directory when git fails. (Closed)

Created:
8 years, 2 months ago by Bob Nystrom

Modified:
8 years, 2 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Print out the working directory when git fails. Also (sigh) re-enabling Windows again. Committed: https://code.google.com/p/dart/source/detail?r=13451

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -5 lines)			Patch
M	utils/pub/git.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	utils/pub/io.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/pub.dart	View	2 chunks	+3 lines, -3 lines	2 comments	Download
M	utils/tests/pub/pub.status	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

One comment, otherwise LGTM. https://codereview.chromium.org/11087039/diff/1/utils/pub/pub.dart File utils/pub/pub.dart (right): https://codereview.chromium.org/11087039/diff/1/utils/pub/pub.dart#newcode227 utils/pub/pub.dart:227: 'currentWorkingDir.'; This should be $currentWorkingDir.

8 years, 2 months ago (2012-10-10 00:17:11 UTC) #2

Bob Nystrom

8 years, 2 months ago (2012-10-10 00:20:51 UTC) #3

https://codereview.chromium.org/11087039/diff/1/utils/pub/pub.dart
File utils/pub/pub.dart (right):

https://codereview.chromium.org/11087039/diff/1/utils/pub/pub.dart#newcode227
utils/pub/pub.dart:227: 'currentWorkingDir.';
On 2012/10/10 00:17:11, nweiz wrote:
> This should be $currentWorkingDir.

Argh. Good catch. This got reverted anyway.

Expand Messages | Collapse Messages