Issue 11087034: Fixing path.relativeTo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11087034: Fixing path.relativeTo. (Closed)

Created:
8 years, 2 months ago by blois

Modified:
8 years, 2 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Improving path.relativeTo to add support for a broader set of absolute paths. I had made a last minute change in my previous CL (changing from a string operation to using hasTrailingSeparator), but forgot to test it. First change is the original, second has the fix. BUG= Committed: https://code.google.com/p/dart/source/detail?r=13435

Patch Set 1 #

Patch Set 2 : Changing hasTrailingSeparator. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -2 lines)			Patch
	M	runtime/bin/path_impl.dart	View	1	1 chunk	+25 lines, -1 line	0 comments	Download
	M	tests/standalone/io/path_test.dart	View		3 chunks	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages