Fix to dartbug.com/5170, explictly static library variables now get an appropriate error message.

Fix to dartbug.com/5170, explictly static library variables now get an appropriate error message.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=13460

[ahe, 2012-10-09 10:20:09]

http://codereview.chromium.org/11087025/diff/2001/lib/compiler/implementation...
File lib/compiler/implementation/resolver.dart (right):

http://codereview.chromium.org/11087025/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/resolver.dart:316: TreeElements resolveField(Element
element) {
Element -> VariableElement.

http://codereview.chromium.org/11087025/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/resolver.dart:318: if(element.modifiers.isStatic()
&& element.getEnclosingClassOrCompilationUnit().isCompilationUnit()) {
Long line.

http://codereview.chromium.org/11087025/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/resolver.dart:318: if(element.modifiers.isStatic()
&& element.getEnclosingClassOrCompilationUnit().isCompilationUnit()) {
I think it should element.variables.isTopLevel(), not element.getEnclosing...

[jwren, 2012-10-09 10:31:15]

http://codereview.chromium.org/11087025/diff/2001/lib/compiler/implementation...
File lib/compiler/implementation/resolver.dart (right):

http://codereview.chromium.org/11087025/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/resolver.dart:316: TreeElements resolveField(Element
element) {
On 2012/10/09 10:20:09, ahe wrote:
> Element -> VariableElement.

Done.

http://codereview.chromium.org/11087025/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/resolver.dart:318: if(element.modifiers.isStatic()
&& element.getEnclosingClassOrCompilationUnit().isCompilationUnit()) {
On 2012/10/09 10:20:09, ahe wrote:
> I think it should element.variables.isTopLevel(), not element.getEnclosing...

Done- changing it to element.variables.isTopLevel() shorten the length of the
line down to 73 chars.

[ahe, 2012-10-09 10:55:28]

LGTM, but I would like to tweak the diagnostic.

http://codereview.chromium.org/11087025/diff/5/lib/compiler/implementation/re...
File lib/compiler/implementation/resolver.dart (right):

http://codereview.chromium.org/11087025/diff/5/lib/compiler/implementation/re...
lib/compiler/implementation/resolver.dart:319: error(tree,
MessageKind.LIBRARY_VARIABLE_AS_STATIC, [element.name]);
The position should be the static keyword, I think.

http://codereview.chromium.org/11087025/diff/5/lib/compiler/implementation/wa...
File lib/compiler/implementation/warnings.dart (right):

http://codereview.chromium.org/11087025/diff/5/lib/compiler/implementation/wa...
lib/compiler/implementation/warnings.dart:302: "The library variable '#{1}' is
implicitly static, but is also declared as static, remove the static keyword.");
Long line.

http://codereview.chromium.org/11087025/diff/5/lib/compiler/implementation/wa...
lib/compiler/implementation/warnings.dart:302: "The library variable '#{1}' is
implicitly static, but is also declared as static, remove the static keyword.");
library variable -> top-level variable.

I think this error should just be:

"top-level variable cannot be declared static"

[jwren, 2012-10-09 12:55:26]

http://codereview.chromium.org/11087025/diff/5/lib/compiler/implementation/re...
File lib/compiler/implementation/resolver.dart (right):

http://codereview.chromium.org/11087025/diff/5/lib/compiler/implementation/re...
lib/compiler/implementation/resolver.dart:319: error(tree,
MessageKind.LIBRARY_VARIABLE_AS_STATIC, [element.name]);
On 2012/10/09 10:55:28, ahe wrote:
> The position should be the static keyword, I think.

Done.

http://codereview.chromium.org/11087025/diff/5/lib/compiler/implementation/wa...
File lib/compiler/implementation/warnings.dart (right):

http://codereview.chromium.org/11087025/diff/5/lib/compiler/implementation/wa...
lib/compiler/implementation/warnings.dart:302: "The library variable '#{1}' is
implicitly static, but is also declared as static, remove the static keyword.");
On 2012/10/09 10:55:28, ahe wrote:
> library variable -> top-level variable.
> 
> I think this error should just be:
> 
> "top-level variable cannot be declared static"

Done.

[ahe, 2012-10-09 14:30:19]

LGTM!

http://codereview.chromium.org/11087025/diff/4002/lib/compiler/implementation...
File lib/compiler/implementation/resolver.dart (right):

http://codereview.chromium.org/11087025/diff/4002/lib/compiler/implementation...
lib/compiler/implementation/resolver.dart:319:
error(element.modifiers.getStatic(),
MessageKind.TOP_LEVEL_VARIABLE_DECLARED_STATIC);
Long line.