Give different runtime type representations to different types with the same name.

Give different runtime type representations to different types with the same name.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=13543

[kasperl, 2012-10-11 13:18:51]

LGTM (except for the missing id++).

http://codereview.chromium.org/11086074/diff/2001/lib/compiler/implementation...
File lib/compiler/implementation/runtime_types.dart (right):

http://codereview.chromium.org/11086074/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/runtime_types.dart:16: * detect elements with the
same name and add a library prefix to them.
You're not really adding a library prefix to them.

http://codereview.chromium.org/11086074/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/runtime_types.dart:26: name = '$guess@$id';
You need to increase id in here.

http://codereview.chromium.org/11086074/diff/2001/tests/language/first_class_...
File tests/language/first_class_types_libraries_test.dart (right):

http://codereview.chromium.org/11086074/diff/2001/tests/language/first_class_...
tests/language/first_class_types_libraries_test.dart:5:
#import('first_class_types_lib1.dart', prefix: 'lib1');
Use new import syntax?

http://codereview.chromium.org/11086074/diff/2001/tests/language/first_class_...
tests/language/first_class_types_libraries_test.dart:17:
Expect.isFalse(a.runtimeType === b.runtimeType);
Use identical.

[karlklose, 2012-10-11 13:29:42]

Thanks Kasper!

http://codereview.chromium.org/11086074/diff/2001/lib/compiler/implementation...
File lib/compiler/implementation/runtime_types.dart (right):

http://codereview.chromium.org/11086074/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/runtime_types.dart:16: * detect elements with the
same name and add a library prefix to them.
On 2012/10/11 13:18:51, kasperl wrote:
> You're not really adding a library prefix to them.

Done.

http://codereview.chromium.org/11086074/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/runtime_types.dart:26: name = '$guess@$id';
On 2012/10/11 13:18:51, kasperl wrote:
> You need to increase id in here.

Done.

http://codereview.chromium.org/11086074/diff/2001/tests/language/first_class_...
File tests/language/first_class_types_libraries_test.dart (right):

http://codereview.chromium.org/11086074/diff/2001/tests/language/first_class_...
tests/language/first_class_types_libraries_test.dart:5:
#import('first_class_types_lib1.dart', prefix: 'lib1');
On 2012/10/11 13:18:51, kasperl wrote:
> Use new import syntax?

Done.

http://codereview.chromium.org/11086074/diff/2001/tests/language/first_class_...
tests/language/first_class_types_libraries_test.dart:17:
Expect.isFalse(a.runtimeType === b.runtimeType);
On 2012/10/11 13:18:51, kasperl wrote:
> Use identical.

Done.

[ngeoffray, 2012-10-15 12:57:55]

http://codereview.chromium.org/11086074/diff/8001/lib/compiler/implementation...
File lib/compiler/implementation/runtime_types.dart (right):

http://codereview.chromium.org/11086074/diff/8001/lib/compiler/implementation...
lib/compiler/implementation/runtime_types.dart:21: String getName(Element
element) {
This very much look like code dealt else where. Coud it somehow be shared?

http://codereview.chromium.org/11086074/diff/8001/lib/compiler/implementation...
lib/compiler/implementation/runtime_types.dart:71: String elementName =
getName(element);
Use the namer instead?