Issue 11086065: - Generate a version string based on the VERSION file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11086065: - Generate a version string based on the VERSION file. (Closed)

Created:
8 years, 2 months ago by Ivan Posva

Modified:
8 years, 2 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Generate a version string based on the VERSION file. - Add a Dart_VersionString to the API. - Print version string when passing --version to the standalone binary. Committed: https://code.google.com/p/dart/source/detail?r=13514

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+200 lines, -7 lines)			Patch
M	runtime/bin/bin.gypi	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/main.cc	View	6 chunks	+28 lines, -7 lines	0 comments	Download
M	runtime/dart-runtime.gyp	View	6 chunks	+34 lines, -0 lines	0 comments	Download
M	runtime/include/dart_api.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A	runtime/tools/make_version.py	View	1 chunk	+90 lines, -0 lines	2 comments	Download
M	runtime/vm/dart_api_impl.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
A	runtime/vm/version.h	View	1 chunk	+22 lines, -0 lines	0 comments	Download
A	runtime/vm/version_in.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ricow1

https://codereview.chromium.org/11086065/diff/1/runtime/tools/make_version.py File runtime/tools/make_version.py (right): https://codereview.chromium.org/11086065/diff/1/runtime/tools/make_version.py#newcode16 runtime/tools/make_version.py:16: proc = subprocess.Popen(['awk', this will not work on windows ...

8 years, 2 months ago (2012-10-11 07:35:24 UTC) #2

ahe

8 years, 2 months ago (2012-10-11 12:37:29 UTC) #3

This is breaking my build:

make_version.py exception
list index out of range
make: *** [out/ReleaseIA32/obj/gen/version.cc] Error 255
make: *** Waiting for unfinished jobs....

$ git svn info
git: 'svn' is not a git command. See 'git --help'.

Did you mean this?
	sync
$ svn info
svn: '.' is not a working copy

Expand Messages | Collapse Messages