Issue 11086044: Remove support for optimized dart leaf functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11086044: Remove support for optimized dart leaf functions. (Closed)

Created:
8 years, 2 months ago by Florian Schneider

Modified:
8 years, 2 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove support for optimized dart leaf functions. This optimization does not bring any benefit since all functions have at least a call in the slow-path of the stack-overflow check. I'm suggesting to remove support for this optimization since it does not get triggered currently, therefore is also not tested. Plus we have inlining now, which already makes calls to (small enough) leaf functions fast. Committed: https://code.google.com/p/dart/source/detail?r=13555

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -149 lines)			Patch
M	runtime/vm/assembler_macros_ia32.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/assembler_macros_ia32.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	runtime/vm/assembler_macros_x64.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/assembler_macros_x64.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	runtime/vm/compiler.cc	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	4 chunks	+1 line, -11 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View	3 chunks	+1 line, -7 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	8 chunks	+1 line, -23 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	3 chunks	+1 line, -7 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	8 chunks	+1 line, -26 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 chunk	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM and thanks for the cleanup.

Expand Messages | Collapse Messages