Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 11086033: Make verifiedLocale work differently depending on what it's verifying for (Closed)

Created:
8 years, 2 months ago by Alan Knight
Modified:
8 years, 2 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org, danielro_google.com
Visibility:
Public.

Description

Make verifiedLocale work differently depending on what it's verifying for Committed: https://code.google.com/p/dart/source/detail?r=13484

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -39 lines) Patch
M pkg/intl/example/basic/basic_example.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/intl/example/basic/messages_all.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/intl/example/basic/messages_de.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/intl/example/basic/messages_de_de.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M pkg/intl/lib/date_format.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/intl/lib/intl.dart View 1 4 chunks +40 lines, -16 lines 0 comments Download
M pkg/intl/lib/message_lookup_local.dart View 2 chunks +17 lines, -2 lines 0 comments Download
M pkg/intl/lib/number_format.dart View 2 chunks +10 lines, -1 line 0 comments Download
M pkg/intl/test/intl_message_basic_example_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Alan Knight
This changes verifiedLocale to look at the appropriate set of locales for each purpose, so ...
8 years, 2 months ago (2012-10-09 22:40:46 UTC) #1
Emily Fortuna
8 years, 2 months ago (2012-10-09 23:37:55 UTC) #2
lgtm with typo fix.

+danielro@google.com on the cc list: The part here that's relevant to you, is if
you have translated messages that are only for the more general locale "en"
instead of en_US and en_GB, then you can create a file whose name is
messages_en.dart and the library will fall back to this for the general case, if
more specific localization info is not available.

https://codereview.chromium.org/11086033/diff/1/pkg/intl/lib/intl.dart
File pkg/intl/lib/intl.dart (right):

https://codereview.chromium.org/11086033/diff/1/pkg/intl/lib/intl.dart#newcode43
pkg/intl/lib/intl.dart:43: *      today(date) => Intl.message(
good catch.

https://codereview.chromium.org/11086033/diff/1/pkg/intl/lib/intl.dart#newcod...
pkg/intl/lib/intl.dart:227: * it can be a wrapper around a message function that
takes aerguments, or it
typo: arguments

Powered by Google App Engine
This is Rietveld 408576698