Issue 11085083: [dart2dart] Triage test failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11085083: [dart2dart] Triage test failures. (Closed)

Created:
8 years, 2 months ago by Roman

Modified:
8 years, 2 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

[dart2dart] Triage test failures. Committed: https://code.google.com/p/dart/source/detail?r=13567

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -78 lines)			Patch
	M	tests/co19/co19-dart2dart.status	View	1	9 chunks	+75 lines, -78 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm and thanks https://codereview.chromium.org/11085083/diff/1/tests/co19/co19-dart2dart.status File tests/co19/co19-dart2dart.status (right): https://codereview.chromium.org/11085083/diff/1/tests/co19/co19-dart2dart.status#newcode273 tests/co19/co19-dart2dart.status:273: Language/10_Expressions/11_Instance_Creation/1_New_A12_t01: Fail # Bug in test? ...

8 years, 2 months ago (2012-10-11 17:55:23 UTC) #2

Roman

8 years, 2 months ago (2012-10-11 18:09:14 UTC) #3

https://codereview.chromium.org/11085083/diff/1/tests/co19/co19-dart2dart.status
File tests/co19/co19-dart2dart.status (right):

https://codereview.chromium.org/11085083/diff/1/tests/co19/co19-dart2dart.sta...
tests/co19/co19-dart2dart.status:273:
Language/10_Expressions/11_Instance_Creation/1_New_A12_t01: Fail # Bug in test?
(Unmatched bracket)
On 2012/10/11 17:55:23, Anton Muhin wrote:
> does it fail under dart2js?

Yes, created co19 issue.

Expand Messages | Collapse Messages

Issue 11085083: [dart2dart] Triage test failures. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages