Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 11085020: Revert "Address Peter's comments on Function.apply." (Closed)

Created:
8 years, 2 months ago by floitsch
Modified:
8 years, 2 months ago
Reviewers:
ahe, ngeoffray
CC:
reviews_dartlang.org, ngeoffray
Visibility:
Public.

Description

Revert "Address Peter's comments on Function.apply." This reverts commit 13416. Committed: https://code.google.com/p/dart/source/detail?r=13417

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -42 lines) Patch
M lib/compiler/implementation/compiler.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M lib/compiler/implementation/lib/core_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/lib/js_helper.dart View 1 chunk +39 lines, -39 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
TBR. Unbreaks build.
8 years, 2 months ago (2012-10-09 15:30:22 UTC) #1
ahe
LGTM!
8 years, 2 months ago (2012-10-09 15:30:41 UTC) #2
ngeoffray
Thanks Florian
8 years, 2 months ago (2012-10-09 15:54:56 UTC) #3
ngeoffray
8 years, 2 months ago (2012-10-09 16:07:18 UTC) #4
Peter: the reason it failed is because the applyFunction is always being
enqueued because it is in js_helper.dart. Therefore, the apply functionality was
always compiled (and it does not support the old specification for optional
parameters). 

I'm open to suggestions on how to avoid calling ensureResolved on the function
class, that doesn't require having two indirections (Function.apply calls
top-level method, calls js helper).

Powered by Google App Engine
This is Rietveld 408576698