Issue 11081002: Revert r13292. This is when the first failure showed up on dartc, but dartc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11081002: Revert r13292. This is when the first failure showed up on dartc, but dartc (Closed)

Created:
8 years, 2 months ago by Emily Fortuna

Modified:
8 years, 2 months ago

Reviewers:
gram

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Revert r13292. This is when the first failure showed up on dartc, but dartc didn't actually turn red. Investigating why. Committed: https://code.google.com/p/dart/source/detail?r=13330

Patch Set 1 #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -128 lines)			Patch
M	lib/compiler/implementation/lib/core_patch.dart	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	lib/core/function.dart	View	1 chunk	+0 lines, -25 lines	0 comments	Download
D	runtime/lib/function_patch.dart	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	runtime/lib/lib_sources.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/co19/co19-compiler.status	View	1 chunk	+0 lines, -1 line	1 comment	Download
D	tests/corelib/apply_test.dart	View	1 chunk	+0 lines, -79 lines	0 comments	Download
M	tests/corelib/corelib.status	View	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

8 years, 2 months ago (2012-10-05 23:05:08 UTC) #1

Lasse, 
If this doesn't fix the bot problem I'll reapply your change. This is just a
quick experiment since the dartc bots run differently from the dart2js bots.

https://codereview.chromium.org/11081002/diff/1/tests/co19/co19-compiler.status
File tests/co19/co19-compiler.status (left):

https://codereview.chromium.org/11081002/diff/1/tests/co19/co19-compiler.stat...
tests/co19/co19-compiler.status:6: Language/03_Overview/1_Scoping_A02_t05: Fail
# TODO(analyzer-team): Please triage this failure.
This change is added specifically so I know there should be at least one failure
and cause the bot to turn red. If the bot turns red, we'll know the rest of this
CL managed to confuse the output of the buildbot.

Expand Messages | Collapse Messages