Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2534)

Issue 1107753002: Support profiling of simulated Dart code on mips, arm, and arm64. (Closed)

Created:
5 years, 8 months ago by regis
Modified:
5 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Support profiling of simulated Dart code on mips, arm, and arm64. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45430

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -17 lines) Patch
M runtime/vm/constants_arm.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/constants_arm64.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/constants_mips.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/profiler.cc View 1 7 chunks +38 lines, -11 lines 0 comments Download
M runtime/vm/simulator_arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/simulator_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/simulator_arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/simulator_arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/simulator_mips.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/simulator_mips.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
regis
I still need to check if the lr_ field of a sample is really used, ...
5 years, 8 months ago (2015-04-24 23:00:45 UTC) #2
Cutch
On 2015/04/24 23:00:45, regis wrote: > I still need to check if the lr_ field ...
5 years, 8 months ago (2015-04-24 23:05:24 UTC) #3
regis
Sounds good. The link register is now set properly. PTAL Thanks, Regis
5 years, 8 months ago (2015-04-25 00:08:21 UTC) #4
Cutch
lgtm
5 years, 8 months ago (2015-04-27 19:55:23 UTC) #5
regis
5 years, 8 months ago (2015-04-27 19:56:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r45430 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698