Issue 1107663002: Fix http://dartbug.com/23290

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1107663002: Fix http://dartbug.com/23290 (Closed)

Created:
5 years, 8 months ago by Ivan Posva

Modified:
5 years, 8 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix http://dartbug.com/23290 - Ensure that we do have unoptimized code available when generating coverage information. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45419

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -55 lines)			Patch
M	runtime/vm/code_generator.cc	View	1	2 chunks	+12 lines, -5 lines	0 comments	Download
M	runtime/vm/compiler.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/compiler.cc	View	1	4 chunks	+9 lines, -4 lines	0 comments	Download
M	runtime/vm/coverage.cc	View	1	3 chunks	+21 lines, -23 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	1	1 chunk	+7 lines, -1 line	0 comments	Download
M	runtime/vm/deferred_objects.cc	View	1	4 chunks	+28 lines, -13 lines	0 comments	Download
M	runtime/vm/deopt_instructions.cc	View	1	1 chunk	+8 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1	2 chunks	+11 lines, -5 lines	0 comments	Download

Total messages: 4 (1 generated)

Ivan Posva

5 years, 8 months ago (2015-04-24 23:31:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r45419 (presubmit successful).