Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1107613002: Move symbol demangling to dart:_internal to remove dart:core dependency on dart:mirrors. (Closed)

Created:
5 years, 8 months ago by rmacnak
Modified:
5 years, 8 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Move symbol demangling to dart:_internal to remove dart:core dependency on dart:mirrors. BUG= R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -47 lines) Patch
M runtime/lib/errors_patch.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/lib/mirrors_impl.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/mirrors_patch.dart View 3 chunks +3 lines, -38 lines 0 comments Download
M runtime/lib/symbol_patch.dart View 1 chunk +40 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
5 years, 8 months ago (2015-04-23 20:20:17 UTC) #2
rmacnak
5 years, 8 months ago (2015-04-24 17:25:00 UTC) #4
srdjan
lgtm
5 years, 8 months ago (2015-04-24 17:32:36 UTC) #5
rmacnak
5 years, 8 months ago (2015-04-24 17:50:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45405 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698