Issue 1107213003: Fix idle ticks during isolate startup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1107213003: Fix idle ticks during isolate startup (Closed)

Created:
5 years, 8 months ago by Cutch

Modified:
5 years, 8 months ago

Reviewers:
rmacnak, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Fix idle ticks during isolate startup - Change default isolate vm tag from idle to Embedder - When a thread is exiting an isolate, only set the Idle tag if the isolate has been made runnable. Set LoadWait tag otherwise. R=iposva@google.com, rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=45436

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
M	runtime/vm/isolate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/tags.h	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/thread.cc	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download

Total messages: 7 (1 generated)

Ivan Posva

On 2015/04/27 23:28:06, rmacnak wrote: > lgtm I need to understand this first... -ivan

5 years, 8 months ago (2015-04-27 23:28:50 UTC) #4

Cutch

5 years, 8 months ago (2015-04-28 00:32:54 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 45436 (presubmit successful).