Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11071015: Fix error reporting on member declarations. (Closed)

Created:
8 years, 2 months ago by karlklose
Modified:
8 years, 2 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix error reporting on member declarations. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=13347

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rename method and add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M lib/compiler/implementation/scanner/listener.dart View 1 2 chunks +11 lines, -0 lines 0 comments Download
M lib/compiler/implementation/scanner/parser.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
A + tests/language/illegal_declaration_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
karlklose
8 years, 2 months ago (2012-10-08 08:39:37 UTC) #1
ahe
LGTM! http://codereview.chromium.org/11071015/diff/1/lib/compiler/implementation/scanner/listener.dart File lib/compiler/implementation/scanner/listener.dart (right): http://codereview.chromium.org/11071015/diff/1/lib/compiler/implementation/scanner/listener.dart#newcode556 lib/compiler/implementation/scanner/listener.dart:556: Link<Token> expectedMemberDeclaration(Token token) { This should probably be: ...
8 years, 2 months ago (2012-10-08 08:42:06 UTC) #2
karlklose
http://codereview.chromium.org/11071015/diff/1/lib/compiler/implementation/scanner/listener.dart File lib/compiler/implementation/scanner/listener.dart (right): http://codereview.chromium.org/11071015/diff/1/lib/compiler/implementation/scanner/listener.dart#newcode556 lib/compiler/implementation/scanner/listener.dart:556: Link<Token> expectedMemberDeclaration(Token token) { On 2012/10/08 08:42:06, ahe wrote: ...
8 years, 2 months ago (2012-10-08 09:01:37 UTC) #3
ahe
8 years, 2 months ago (2012-10-08 09:03:11 UTC) #4 
LGTM!

Powered by Google App Engine
This is Rietveld 408576698