Issue 110703004: VM: Generalize using propagated cids for to >1 arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 110703004: VM: Generalize using propagated cids for to >1 arguments. (Closed)

Created:
7 years ago by Florian Schneider

Modified:
7 years ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

VM: Generalize using propagated cids for to >1 arguments. When ic-data are missing (optimized code that was not executed yet), the compiler tries to fill in information calculated with type propagation. The approach was only used for calls with 1 tested argument. This enables it for all calls where we want to use propagated type information if ic-data are missing. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31020

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View		2 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

The cast >1 arguments is already covered by existing tests.

7 years ago (2013-12-10 14:52:44 UTC) #1

Florian Schneider

7 years ago (2013-12-10 15:23:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r31020 (presubmit successful).

Expand Messages | Collapse Messages