Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 11068022: FormData is FormData in all browsers. (Closed)

Created:
8 years, 2 months ago by podivilov
Modified:
8 years, 2 months ago
Reviewers:
vsm, Anton Muhin, podivilov1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M lib/compiler/implementation/lib/native_helper.dart View 4 chunks +0 lines, -5 lines 2 comments Download
M tests/html/html.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
podivilov
8 years, 2 months ago (2012-10-05 16:41:56 UTC) #1
vsm
https://codereview.chromium.org/11068022/diff/1/lib/compiler/implementation/lib/native_helper.dart File lib/compiler/implementation/lib/native_helper.dart (left): https://codereview.chromium.org/11068022/diff/1/lib/compiler/implementation/lib/native_helper.dart#oldcode20 lib/compiler/implementation/lib/native_helper.dart:20: if (name == 'FormData') return 'DOMFormData'; Are you sure ...
8 years, 2 months ago (2012-10-05 17:03:17 UTC) #2
podivilov1
https://codereview.chromium.org/11068022/diff/1/lib/compiler/implementation/lib/native_helper.dart File lib/compiler/implementation/lib/native_helper.dart (left): https://codereview.chromium.org/11068022/diff/1/lib/compiler/implementation/lib/native_helper.dart#oldcode20 lib/compiler/implementation/lib/native_helper.dart:20: if (name == 'FormData') return 'DOMFormData'; On 2012/10/05 17:03:17, ...
8 years, 2 months ago (2012-10-05 17:23:07 UTC) #3
vsm
8 years, 2 months ago (2012-10-05 17:25:43 UTC) #4
Thanks for checking.  LGTM.

Powered by Google App Engine
This is Rietveld 408576698