Support defining environment constants for dart2js via the command-line.

Support defining environment constants for dart2js via the command-line.

These constants only work for dart2js because neither Dartium nor the isolate
API support defining them.

BUG= http://dartbug.com/15806
R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45416

[nweiz, 2015-04-24 00:14:26]

nweiz@google.com changed reviewers:
+ rnystrom@google.com

[kevmoo, 2015-04-24 00:23:14]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2015-04-24 00:23:14]

DBC

https://codereview.chromium.org/1106713003/diff/1/sdk/lib/_internal/pub/test/...
File sdk/lib/_internal/pub/test/dart2js/environment_constant_test.dart (right):

https://codereview.chromium.org/1106713003/diff/1/sdk/lib/_internal/pub/test/...
sdk/lib/_internal/pub/test/dart2js/environment_constant_test.dart:29:
schedulePub(args: ["build", "--define", "name=fblthp"],
Can I define many variables this way?

[nweiz, 2015-04-24 00:26:48]

https://codereview.chromium.org/1106713003/diff/1/sdk/lib/_internal/pub/test/...
File sdk/lib/_internal/pub/test/dart2js/environment_constant_test.dart (right):

https://codereview.chromium.org/1106713003/diff/1/sdk/lib/_internal/pub/test/...
sdk/lib/_internal/pub/test/dart2js/environment_constant_test.dart:29:
schedulePub(args: ["build", "--define", "name=fblthp"],
On 2015/04/24 00:23:14, kevmoo wrote:
> Can I define many variables this way?

Yes, it passes allowMultiple to ArgParser.addOption.

[Bob Nystrom, 2015-04-24 21:33:10]

https://codereview.chromium.org/1106713003/diff/1/sdk/lib/_internal/pub/lib/s...
File sdk/lib/_internal/pub/lib/src/command/build.dart (right):

https://codereview.chromium.org/1106713003/diff/1/sdk/lib/_internal/pub/lib/s...
sdk/lib/_internal/pub/lib/src/command/build.dart:40: allowMultiple: true,
splitCommas: false);
Why make splitCommas false?

https://codereview.chromium.org/1106713003/diff/1/sdk/lib/_internal/pub/lib/s...
File sdk/lib/_internal/pub/lib/src/utils.dart (right):

https://codereview.chromium.org/1106713003/diff/1/sdk/lib/_internal/pub/lib/s...
sdk/lib/_internal/pub/lib/src/utils.dart:374: /// Returns a new map with all
values in both [map1] and [map2].
"values" -> "entries".

https://codereview.chromium.org/1106713003/diff/1/sdk/lib/_internal/pub/lib/s...
sdk/lib/_internal/pub/lib/src/utils.dart:376: /// If there are conflicting keys,
[map2]'s value wins.
"conflicting" -> "overlapping".

https://codereview.chromium.org/1106713003/diff/1/sdk/lib/_internal/pub/lib/s...
sdk/lib/_internal/pub/lib/src/utils.dart:378: var result = {};
result.addAll(map1);
result.addAll(map2);

[nweiz, 2015-04-24 21:37:42]

Code review changes

[nweiz, 2015-04-24 21:38:06]

https://codereview.chromium.org/1106713003/diff/1/sdk/lib/_internal/pub/lib/s...
File sdk/lib/_internal/pub/lib/src/command/build.dart (right):

https://codereview.chromium.org/1106713003/diff/1/sdk/lib/_internal/pub/lib/s...
sdk/lib/_internal/pub/lib/src/command/build.dart:40: allowMultiple: true,
splitCommas: false);
On 2015/04/24 21:33:09, Bob Nystrom wrote:
> Why make splitCommas false?

Because there's nothing stopping environment constants from containing commas.
Also, it would be different from how dart2js handles it.

https://codereview.chromium.org/1106713003/diff/1/sdk/lib/_internal/pub/lib/s...
File sdk/lib/_internal/pub/lib/src/utils.dart (right):

https://codereview.chromium.org/1106713003/diff/1/sdk/lib/_internal/pub/lib/s...
sdk/lib/_internal/pub/lib/src/utils.dart:374: /// Returns a new map with all
values in both [map1] and [map2].
On 2015/04/24 21:33:09, Bob Nystrom wrote:
> "values" -> "entries".

Done.

https://codereview.chromium.org/1106713003/diff/1/sdk/lib/_internal/pub/lib/s...
sdk/lib/_internal/pub/lib/src/utils.dart:376: /// If there are conflicting keys,
[map2]'s value wins.
On 2015/04/24 21:33:10, Bob Nystrom wrote:
> "conflicting" -> "overlapping".

Done.

https://codereview.chromium.org/1106713003/diff/1/sdk/lib/_internal/pub/lib/s...
sdk/lib/_internal/pub/lib/src/utils.dart:378: var result = {};
On 2015/04/24 21:33:10, Bob Nystrom wrote:
> result.addAll(map1);
> result.addAll(map2);

Done.

[Bob Nystrom, 2015-04-24 21:39:26]

lgtm

[nweiz, 2015-04-24 21:40:59]

Committed patchset #2 (id:20001) manually as 45416 (presubmit successful).