Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1106613006: dart2js: add classNameFromIsCheckProperty to compiler builtins. (Closed)

Created:
5 years, 8 months ago by floitsch
Modified:
5 years, 7 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: add classNameFromIsCheckProperty to compiler builtins. R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=45537

Patch Set 1 #

Patch Set 2 : Reformat. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -15 lines) Patch
M pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 2 chunks +10 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_rti.dart View 1 chunk +2 lines, -7 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart View 1 chunk +17 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
5 years, 8 months ago (2015-04-24 12:03:13 UTC) #2
floitsch
ping.
5 years, 7 months ago (2015-05-04 19:50:56 UTC) #3
sra1
lgtm
5 years, 7 months ago (2015-05-05 19:07:21 UTC) #4
floitsch
5 years, 7 months ago (2015-05-05 19:32:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45537 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698