Issue 11066066: Include stderr on git failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11066066: Include stderr on git failure. (Closed)

Created:
8 years, 2 months ago by Bob Nystrom

Modified:
8 years, 2 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Include stderr on git failure. Also moves the git stuff out of io into its own library. Committed: https://code.google.com/p/dart/source/detail?r=13388

Patch Set 2 : Remove test code. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -23 lines)			Patch
A	utils/pub/git.dart	View		1 chunk	+84 lines, -0 lines	0 comments	Download
M	utils/pub/git_source.dart	View	1	5 chunks	+9 lines, -19 lines	0 comments	Download
M	utils/pub/pub.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/source.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/version_solver.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

The git tests are failing with an actual git failure on Windows on the bots, ...

8 years, 2 months ago (2012-10-08 23:25:03 UTC) #1

nweiz

lgtm https://codereview.chromium.org/11066066/diff/1/utils/pub/git_source.dart File utils/pub/git_source.dart (right): https://codereview.chromium.org/11066066/diff/1/utils/pub/git_source.dart#newcode154 utils/pub/git_source.dart:154: var args = ["clonee", from, to]; Typo

8 years, 2 months ago (2012-10-09 00:01:19 UTC) #2