Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 11066065: Add back in full exit code information. (Closed)

Created:
8 years, 2 months ago by Emily Fortuna
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add back in full exit code information. Committed: https://code.google.com/p/dart/source/detail?r=13380

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M tools/testing/dart/test_progress.dart View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Emily Fortuna
You were right, Graham -- Windows needs the explicit exit code (the IE bots turned ...
8 years, 2 months ago (2012-10-08 23:09:37 UTC) #1
gram
lgtm
8 years, 2 months ago (2012-10-08 23:25:27 UTC) #2
Mads Ager (google)
I don't understand why this is necessary? If this is necessary, that is a symptom ...
8 years, 2 months ago (2012-10-09 06:22:18 UTC) #3
Emily Fortuna
On 2012/10/09 06:22:18, Mads Ager wrote: > I don't understand why this is necessary? If ...
8 years, 2 months ago (2012-10-09 17:39:26 UTC) #4
Mads Ager (google)
8 years, 2 months ago (2012-10-09 19:10:55 UTC) #5
On 2012/10/09 17:39:26, Emily Fortuna wrote:
> On 2012/10/09 06:22:18, Mads Ager wrote:
> > I don't understand why this is necessary? If this is necessary, that is a
> > symptom of something else that is wrong.
> 
> This was necessary. To see examples where this was failing, look at this
build:
>
http://chromegw.corp.google.com/i/client.dart/builders/dart2js-ie-win7-html/b...
> 
> and then this build after this CL was committed:
>
http://chromegw.corp.google.com/i/client.dart/builders/dart2js-ie-win7-html/b...
> 
> You can see in the previous one, no tests failed, but because it didn't
> explicitly return an exit code of 0, the bot turned "red"

The problem in the one that went wrong was not the exit code. It was that
@@@STEP_FAILURE@@@ was printed at the end. Why that happened I don't know and
that indicates that there is still something fishy with this part of test.dart.

Powered by Google App Engine
This is Rietveld 408576698