Issue 11066004: Issue 5628. Quick fixes should suggest to use existing element with close name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11066004: Issue 5628. Quick fixes should suggest to use existing element with close name (Closed)

Created:
8 years, 2 months ago by scheglov

Modified:
8 years, 2 months ago

Reviewers:
messick

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 5628. Quick fixes should suggest to use existing element with close name http://code.google.com/p/dart/issues/detail?id=5628 R=messick@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=13259

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+477 lines, -180 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/Elements.java	View	2 chunks	+29 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/CorrectionMessages.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/CorrectionMessages.properties	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/QuickFixProcessor.java	View	15 chunks	+273 lines, -159 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/correction/QuickFixProcessorTest.java	View	31 chunks	+172 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

messick

8 years, 2 months ago (2012-10-04 02:25:07 UTC) #2

LGTM

Excellent! This is a great first step, and it may be exactly what we need. Most
spelling correctors allow the user to choose from among a small set of matches.
We might want that someday. If you agree, then please open an issue for that so
we don't forget.

Also, at some point we should talk about whether it makes sense to include
elements defined only in subclasses.

Expand Messages | Collapse Messages