Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 11065042: Introduce ListLikeIDLTypeInfo as a replacement for nativified_classes table. (Closed)

Created:
8 years, 2 months ago by podivilov
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Introduce ListLikeIDLTypeInfo as a replacement for nativified_classes table. IDLTypeInfo hierarchy is a convenient way to deal with idl type polymorfism. R=antonm@google.com,efortuna@google.com,vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=13472

Patch Set 1 #

Total comments: 8

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -66 lines) Patch
M lib/html/scripts/generator.py View 1 9 chunks +64 lines, -54 lines 0 comments Download
M lib/html/scripts/htmlrenamer.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M lib/html/scripts/systemhtml.py View 1 4 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
podivilov
8 years, 2 months ago (2012-10-05 18:00:19 UTC) #1
Emily Fortuna
Nice! I'm adding Pete, who worked on NodeList to ensure it's good, but everything else ...
8 years, 2 months ago (2012-10-05 18:26:08 UTC) #2
podivilov
http://codereview.chromium.org/11065042/diff/1/lib/html/scripts/generator.py File lib/html/scripts/generator.py (right): http://codereview.chromium.org/11065042/diff/1/lib/html/scripts/generator.py#newcode755 lib/html/scripts/generator.py:755: # TODO(podivilov): why NodeList is special? Is it indeed ...
8 years, 2 months ago (2012-10-05 19:59:19 UTC) #3
Anton Muhin
lgtm http://codereview.chromium.org/11065042/diff/1/lib/html/scripts/generator.py File lib/html/scripts/generator.py (right): http://codereview.chromium.org/11065042/diff/1/lib/html/scripts/generator.py#newcode739 lib/html/scripts/generator.py:739: # Type info for DOM types that are ...
8 years, 2 months ago (2012-10-10 07:44:00 UTC) #4
podivilov
8 years, 2 months ago (2012-10-10 13:24:06 UTC) #5
https://codereview.chromium.org/11065042/diff/1/lib/html/scripts/generator.py
File lib/html/scripts/generator.py (right):

https://codereview.chromium.org/11065042/diff/1/lib/html/scripts/generator.py...
lib/html/scripts/generator.py:739: # Type info for DOM types that are converted
to built-in dart types
On 2012/10/10 07:44:00, Anton Muhin wrote:
> comment is somewhat at odds with the name of the class: you promise here
> built-in dart type, but class name is ListLike.

Done.

https://codereview.chromium.org/11065042/diff/1/lib/html/scripts/generator.py...
lib/html/scripts/generator.py:757: if self.idl_type() == 'NodeList':
On 2012/10/10 07:44:00, Anton Muhin wrote:
> if not has_generated_interface(): return self.idl_type()?

Done.

Powered by Google App Engine
This is Rietveld 408576698