Issue 11065036: Make test.dart executable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11065036: Make test.dart executable. (Closed)

Created:
8 years, 2 months ago by ahe

Modified:
8 years, 2 months ago

Reviewers:
ricow1, Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make test.dart executable. Committed: https://code.google.com/p/dart/source/detail?r=13282

Patch Set 1 #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -1 line)			Patch
M	dart/tools/test.dart	View	1 chunk	+1 line, -1 line	1 comment	Download
A	dart/tools/testing/bin/darwin10.0	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	dart/tools/testing/bin/linux-gnu	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

The two added files are symlinks. I don't know if it works, and will carefully ...

8 years, 2 months ago (2012-10-05 10:30:16 UTC) #1

ricow1

8 years, 2 months ago (2012-10-05 10:48:58 UTC) #3

LGTM

https://codereview.chromium.org/11065036/diff/1/dart/tools/test.dart
File dart/tools/test.dart (right):

https://codereview.chromium.org/11065036/diff/1/dart/tools/test.dart#newcode1
dart/tools/test.dart:1: #!/bin/bash -c
exec$IFS"${0%/*}"/testing/bin/$OSTYPE/dart$IFS"$0"$IFS"$@"
This is pretty magical if people did not actually look at the progress to get
here, maybe add a comment?

Expand Messages | Collapse Messages