Issue 11065003: Convert between Dart and JavaScript SerializedScriptValues on postMessage.

Issue 11065003: Convert between Dart and JavaScript SerializedScriptValues on postMessage. (Closed)

Created:
8 years, 2 months ago by sra1

Modified:
8 years, 2 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org, Jacob

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Convert between Dart and JavaScript SerializedScriptValues on postMessage. Committed: https://code.google.com/p/dart/source/detail?r=13311

Patch Set 3 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+321 lines, -95 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View		10 chunks	+87 lines, -19 lines	0 comments	Download
M	lib/html/scripts/generator.py	View	1	1 chunk	+62 lines, -62 lines	0 comments	Download
M	lib/html/src/dart2js_Conversions.dart	View	1 2	5 chunks	+32 lines, -14 lines	0 comments	Download
A	tests/html/postmessage_structured_test.dart	View	1	1 chunk	+140 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sra1

Dart Map values sent from dart2js Dart code are converted into Objects and vice-versa.

8 years, 2 months ago (2012-10-04 04:19:40 UTC) #1

vsm

https://codereview.chromium.org/11065003/diff/5001/lib/html/scripts/generator.py File lib/html/scripts/generator.py (right): https://codereview.chromium.org/11065003/diff/5001/lib/html/scripts/generator.py#newcode517 lib/html/scripts/generator.py:517: # "TYPE DIRECTION" -> conversion This is for the ...

8 years, 2 months ago (2012-10-04 16:03:35 UTC) #2

sra1

Added complex graphs. PTAL https://codereview.chromium.org/11065003/diff/5001/lib/html/scripts/generator.py File lib/html/scripts/generator.py (right): https://codereview.chromium.org/11065003/diff/5001/lib/html/scripts/generator.py#newcode517 lib/html/scripts/generator.py:517: # "TYPE DIRECTION" -> conversion ...

8 years, 2 months ago (2012-10-05 02:15:29 UTC) #3

vsm

8 years, 2 months ago (2012-10-05 17:22:16 UTC) #4

lgtm

https://codereview.chromium.org/11065003/diff/4003/lib/html/src/dart2js_Conve...
File lib/html/src/dart2js_Conversions.dart (right):

https://codereview.chromium.org/11065003/diff/4003/lib/html/src/dart2js_Conve...
lib/html/src/dart2js_Conversions.dart:142: /// Since May modify original.  If
so, action is idempotent.
This comment looks incomplete.  Can you fix?

Expand Messages | Collapse Messages