Issue 1106443003: Optimize DateTime properties

Issue 1106443003: Optimize DateTime properties (Closed)

Created:
5 years, 8 months ago by sra1

Modified:
5 years, 7 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Optimize DateTime properties Several small pieces fit together to improve calendar arithmetic code in a customer's app. 1. Mark DateTime primitives that return small integers as returning uint31. 2. uint31 + uint31 -> uint32 in type inference. 3. uint32 / N can be generated as (uint32 / N) | 0 when N >= 2. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=45621 Reverted: https://code.google.com/p/dart/source/detail?r=45625 Committed: https://code.google.com/p/dart/source/detail?r=45829

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+204 lines, -35 lines)			Patch
M	pkg/compiler/lib/src/inferrer/type_graph_nodes.dart	View	2	1 chunk	+8 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/codegen.dart	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart	View	1 2 3	5 chunks	+38 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/types_propagation.dart	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/js_helper.dart	View	1 2 3 4	1 chunk	+12 lines, -12 lines	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_test.dart	View	2	5 chunks	+45 lines, -17 lines	0 comments	Download
A	tests/compiler/dart2js/tdiv_test.dart	View	2	1 chunk	+94 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

sra1

Committed patchset #1 (id:20001) manually as 45621 (presubmit successful).

5 years, 7 months ago (2015-05-07 21:39:27 UTC) #5

sra1

Committed patchset #2 (id:40001) manually as 45625 (presubmit successful).

5 years, 7 months ago (2015-05-08 00:52:40 UTC) #6

sra1

5 years, 7 months ago (2015-05-15 22:36:25 UTC) #7

Message was sent while issue was closed.

Committed patchset #6 (id:120001) manually as 45829 (presubmit successful).