Issue 110573002: Add a test for the basic operations on a test that's flaking in a very odd way

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 110573002: Add a test for the basic operations on a test that's flaking in a very odd way (Closed)

Created:
7 years ago by Alan Knight

Modified:
7 years ago

Reviewers:
Bill Hesse, floitsch, kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a test for the basic operations on a test that's flaking in a very odd way R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=30999

Patch Set 1 #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	pkg/intl/test/date_time_format_test_core.dart	View		1 chunk	+14 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Alan Knight

Committed patchset #1 manually as r30999 (presubmit successful).

7 years ago (2013-12-09 21:07:32 UTC) #3

kustermann

7 years ago (2013-12-10 07:12:22 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/110573002/diff/1/pkg/intl/test/date_time_form...
File pkg/intl/test/date_time_format_test_core.dart (right):

https://codereview.chromium.org/110573002/diff/1/pkg/intl/test/date_time_form...
pkg/intl/test/date_time_format_test_core.dart:438: expect(first.month, 7);
I would do it in a loop, to increase the probability of hitting it.

Expand Messages | Collapse Messages