Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1105453003: Remove public int.is64Bit. (Closed)

Created:
5 years, 8 months ago by srdjan
Modified:
5 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M runtime/lib/compact_hash.dart View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/lib/growable_array.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/lib/integers_patch.dart View 1 3 chunks +4 lines, -3 lines 0 comments Download
M runtime/lib/internal_patch.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/lib/object.cc View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
srdjan
5 years, 8 months ago (2015-04-24 18:00:00 UTC) #2
srdjan
5 years, 8 months ago (2015-04-24 18:21:54 UTC) #4
siva
lgtm https://codereview.chromium.org/1105453003/diff/40001/runtime/lib/object.cc File runtime/lib/object.cc (right): https://codereview.chromium.org/1105453003/diff/40001/runtime/lib/object.cc#newcode323 runtime/lib/object.cc:323: #if defined(TARGET_ARCH_X64) ARCH_IS_64_BIT should be used here.
5 years, 8 months ago (2015-04-24 18:27:07 UTC) #5
srdjan
https://codereview.chromium.org/1105453003/diff/40001/runtime/lib/object.cc File runtime/lib/object.cc (right): https://codereview.chromium.org/1105453003/diff/40001/runtime/lib/object.cc#newcode323 runtime/lib/object.cc:323: #if defined(TARGET_ARCH_X64) On 2015/04/24 18:27:07, siva wrote: > ARCH_IS_64_BIT ...
5 years, 8 months ago (2015-04-24 18:28:46 UTC) #6
srdjan
5 years, 8 months ago (2015-04-24 18:53:13 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as r45407 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698