Issue 11052011: Fix some warnings.

Issue 11052011: Fix some warnings. (Closed)

Created:
8 years, 2 months ago by karlklose

Modified:
8 years, 2 months ago

Reviewers:
ahe, floitsch, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix some warnings. R=floitsch@google.com,ahe@google.com,ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=13212

Patch Set 1 #

Total comments: 10

Patch Set 2 : Address comments. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -45 lines)			Patch
M	lib/compiler/implementation/compiler.dart	View	1	5 chunks	+8 lines, -14 lines	0 comments	Download
M	lib/compiler/implementation/constants.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/dart_backend/backend.dart	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/dart_backend/placeholder_collector.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/elements/elements.dart	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/js_backend/backend.dart	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/js_backend/emitter.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/resolved_visitor.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/resolver.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View	1	4 chunks	+11 lines, -4 lines	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View		4 chunks	+5 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/ssa/nodes.dart	View		13 chunks	+12 lines, -12 lines	0 comments	Download
M	lib/compiler/implementation/ssa/optimize.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/tracer.dart	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/value_range_analyzer.dart	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! There are a few things that could be cleaned up even further. https://chromiumcodereview.appspot.com/11052011/diff/1/lib/compiler/implementation/dart_backend/backend.dart File ...

8 years, 2 months ago (2012-10-03 14:56:32 UTC) #3

karlklose

8 years, 2 months ago (2012-10-04 08:50:00 UTC) #4

Thanks, Florian and Peter.

https://chromiumcodereview.appspot.com/11052011/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/11052011/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:351: ClassNode classNode =
classElement.parseNode(compiler);
On 2012/10/03 14:56:33, ahe wrote:
> Couldn't you change the return type?

Done.

https://chromiumcodereview.appspot.com/11052011/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart
(right):

https://chromiumcodereview.appspot.com/11052011/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:468:
makeNullPlaceholder(typeName.receiver);
On 2012/10/03 14:56:33, ahe wrote:
> node.typeName.asSend().receiver

Done.

https://chromiumcodereview.appspot.com/11052011/diff/1/lib/compiler/implement...
File lib/compiler/implementation/js_backend/emitter.dart (right):

https://chromiumcodereview.appspot.com/11052011/diff/1/lib/compiler/implement...
lib/compiler/implementation/js_backend/emitter.dart:555: FunctionElement
helperElement = compiler.findHelper(helper);
I added a TODO to findHelper.

https://chromiumcodereview.appspot.com/11052011/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/11052011/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/builder.dart:199: FunctionElement function =
element;
I added a TODO and an else branch that throws an internal error in the code
checking the kind above.

https://chromiumcodereview.appspot.com/11052011/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/11052011/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/codegen.dart:2453: FunctionElement helperElement
= compiler.findHelper(helper);
I added a TODO to findHelper.

Expand Messages | Collapse Messages