1. Create a port when a debugger object is created for an isolate, use this

1. Create a port when a debugger object is created for an isolate, use this
   port as the unique ID to represent an isolate in the debugger message
   format.

2. Switch the Event handler API to use an isolate id instead of the isolate
   object itself.

3. Add a unit test case for isolate debugger event handling with an
   interrupt of isolate to ensure that interrupting the isolate runs
   the interrupt event handler.
Committed: https://code.google.com/p/dart/source/detail?r=13207

[siva, 2012-10-03 17:34:00]

synched upto top of tree and resolved conflicts.

[hausner, 2012-10-03 18:53:13]

lgtm

https://chromiumcodereview.appspot.com/11052006/diff/11002/vm/debugger.h
File vm/debugger.h (right):

https://chromiumcodereview.appspot.com/11052006/diff/11002/vm/debugger.h#newc...
vm/debugger.h:291: static void SignalIsolateEvent(EventType type);
Does this function still need to be public now that you moved the signaling of
isolate creation/destruction into the debugger class?

https://chromiumcodereview.appspot.com/11052006/diff/11002/vm/debugger.h#newc...
vm/debugger.h:337: Dart_Port isolate_id_;  // An unique ID for the isolate in
the debugger.
nit: A unique

https://chromiumcodereview.appspot.com/11052006/diff/11002/vm/debugger_api_im...
File vm/debugger_api_impl_test.cc (right):

https://chromiumcodereview.appspot.com/11052006/diff/11002/vm/debugger_api_im...
vm/debugger_api_impl_test.cc:1080: EXPECT_VALID(retval);
Maybe check that test_isolate_id contains a value that is set by the callback
when  it is called. Or have an additional global variable that is used as a
bitset, with each callback kind setting a different bit, then check here that
all 3 callbacks did happen.

[Ivan Posva, 2012-10-03 20:18:57]

Question about the Dart API: We have Dart_IsolateEventHandler and
Dart_IsolateInterruptCallback. Does that mean that both get notified when an
isolate gets interrupted?

Otherwise LGTM
-Ivan

https://chromiumcodereview.appspot.com/11052006/diff/11002/include/dart_debug...
File include/dart_debugger_api.h (right):

https://chromiumcodereview.appspot.com/11052006/diff/11002/include/dart_debug...
include/dart_debugger_api.h:559: * Returns a handle to the isolate object
corresponding to the isolate id.
Is Dart_Isolate really a handle in the Dart API sense? If not, then maybe we
should adjust the comment to be something like "Returns a reference to the
isolate object..." or just "Returns the isolate object...". The second version
actually matches the description further below.

https://chromiumcodereview.appspot.com/11052006/diff/11002/vm/debugger_api_im...
File vm/debugger_api_impl_test.cc (right):

https://chromiumcodereview.appspot.com/11052006/diff/11002/vm/debugger_api_im...
vm/debugger_api_impl_test.cc:1134: void InterruptIsolateRun(uword unused) {
static?

[siva, 2012-10-03 23:59:45]

Yes currently both the callbacks get called. The interrupt
callback which is setup by Dart_Initialize is always NULL.

https://chromiumcodereview.appspot.com/11052006/diff/11002/include/dart_debug...
File include/dart_debugger_api.h (right):

https://chromiumcodereview.appspot.com/11052006/diff/11002/include/dart_debug...
include/dart_debugger_api.h:559: * Returns a handle to the isolate object
corresponding to the isolate id.
It is not a handle so I have changed the comment to "returns the isolate
object..."

On 2012/10/03 20:18:57, Ivan Posva wrote:
> Is Dart_Isolate really a handle in the Dart API sense? If not, then maybe we
> should adjust the comment to be something like "Returns a reference to the
> isolate object..." or just "Returns the isolate object...". The second version
> actually matches the description further below.

https://chromiumcodereview.appspot.com/11052006/diff/11002/vm/debugger.h
File vm/debugger.h (right):

https://chromiumcodereview.appspot.com/11052006/diff/11002/vm/debugger.h#newc...
vm/debugger.h:291: static void SignalIsolateEvent(EventType type);
In the case of interrupts it is still outside and accessed from StackOverflow

On 2012/10/03 18:53:13, hausner wrote:
> Does this function still need to be public now that you moved the signaling of
> isolate creation/destruction into the debugger class?

https://chromiumcodereview.appspot.com/11052006/diff/11002/vm/debugger.h#newc...
vm/debugger.h:337: Dart_Port isolate_id_;  // An unique ID for the isolate in
the debugger.
On 2012/10/03 18:53:13, hausner wrote:
> nit: A unique

Done.

https://chromiumcodereview.appspot.com/11052006/diff/11002/vm/debugger_api_im...
File vm/debugger_api_impl_test.cc (right):

https://chromiumcodereview.appspot.com/11052006/diff/11002/vm/debugger_api_im...
vm/debugger_api_impl_test.cc:1080: EXPECT_VALID(retval);
On 2012/10/03 18:53:13, hausner wrote:
> Maybe check that test_isolate_id contains a value that is set by the callback
> when  it is called. Or have an additional global variable that is used as a
> bitset, with each callback kind setting a different bit, then check here that
> all 3 callbacks did happen.

Done.

https://chromiumcodereview.appspot.com/11052006/diff/11002/vm/debugger_api_im...
vm/debugger_api_impl_test.cc:1134: void InterruptIsolateRun(uword unused) {
On 2012/10/03 20:18:57, Ivan Posva wrote:
> static?

Done.