Issue 11051014: Extract common logic for emitting implementation classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11051014: Extract common logic for emitting implementation classes. (Closed)

Created:
8 years, 2 months ago by podivilov

Modified:
8 years, 2 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Extract common logic for emitting implementation classes. R=antonm@google.com Committed: https://code.google.com/p/dart/source/detail?r=13181

Patch Set 1 #

Patch Set 2 : Refresh html_dartium.dart #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+877 lines, -891 lines)			Patch
M	lib/html/dartium/html_dartium.dart	View	77 chunks	+817 lines, -817 lines	0 comments	Download
M	lib/html/scripts/systemhtml.py	View	6 chunks	+41 lines, -50 lines	0 comments	Download
M	lib/html/scripts/systemnative.py	View	6 chunks	+19 lines, -24 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm, but, please, try to keep patches smaller, e.g. dropping self._implementation_emitter would make a perfect ...

8 years, 2 months ago (2012-10-03 14:33:17 UTC) #2

podivilov

8 years, 2 months ago (2012-10-03 16:04:43 UTC) #3

On 2012/10/03 14:33:17, Anton Muhin wrote:
> lgtm, but, please, try to keep patches smaller, e.g. dropping
> self._implementation_emitter would make a perfect patch on its own.

OK, thanks for review!

Expand Messages | Collapse Messages