Issue 11047021: New cross frame base types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11047021: New cross frame base types (Closed)

Created:
8 years, 2 months ago by vsm

Modified:
8 years, 2 months ago

Reviewers:
podivilov, sra

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

New cross frame base types. Local types (LocalWindow, LocalLocation, LocalHistory) now subtype the corresponding "safe" base type. The _CrossFrameImpl classes implement the safe types. This also fills out Location and History for dart2js. Note for dart2js, I still need to trap returned windows. That's a separate bug. BUG=3836 Committed: https://code.google.com/p/dart/source/detail?r=13252

Patch Set 1 #

Patch Set 2 : Migrate to new syntax #

Patch Set 3 : Regen dart:html #

Created: 8 years, 2 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6117 lines, -6173 lines)			Patch
M	lib/html/dartium/html_dartium.dart	View		170 chunks	+5924 lines, -5895 lines	0 comments	Download
M	lib/html/scripts/htmlrenamer.py	View		4 chunks	+9 lines, -7 lines	0 comments	Download
M	lib/html/scripts/systemhtml.py	View		6 chunks	+29 lines, -10 lines	0 comments	Download
M	lib/html/scripts/systemnative.py	View		6 chunks	+6 lines, -6 lines	0 comments	Download
A	lib/html/src/CrossFrameTypes.dart	View		1 chunk	+34 lines, -0 lines	0 comments	Download
M	lib/html/src/dart2js_DOMImplementation.dart	View	1	2 chunks	+62 lines, -28 lines	0 comments	Download
M	lib/html/src/dart2js_LocationWrapper.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/html/src/native_DOMImplementation.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	lib/html/templates/html/dart2js/html_dart2js.darttemplate	View		2 chunks	+3 lines, -2 lines	0 comments	Download
A +	lib/html/templates/html/dart2js/impl_LocalWindow.darttemplate	View		2 chunks	+2 lines, -2 lines	0 comments	Download
D	lib/html/templates/html/dart2js/impl_Window.darttemplate	View		1 chunk	+0 lines, -142 lines	0 comments	Download
M	lib/html/templates/html/dartium/html_dartium.darttemplate	View		3 chunks	+4 lines, -3 lines	0 comments	Download
A +	lib/html/templates/html/dartium/impl_LocalWindow.darttemplate	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	lib/html/templates/html/dartium/impl_Window.darttemplate	View		1 chunk	+0 lines, -28 lines	0 comments	Download
A +	lib/html/templates/html/interface/interface_LocalWindow.darttemplate	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	lib/html/templates/html/interface/interface_Window.darttemplate	View		1 chunk	+0 lines, -41 lines	0 comments	Download
M	tests/html/cross_frame_test.dart	View		1 chunk	+41 lines, -6 lines	0 comments	Download
M	tests/html/fileapi_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

podivilov

8 years, 2 months ago (2012-10-04 15:57:20 UTC) #2

LGTM.

A better long-term approach would be to add SecureIDLTypeInfo to TypeRegistry
and move all the special handling there.

Expand Messages | Collapse Messages