Issue 11045020: Merge BaseGenerator into HtmlDartInterfaceGenerator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11045020: Merge BaseGenerator into HtmlDartInterfaceGenerator. (Closed)

Created:
8 years, 2 months ago by podivilov

Modified:
8 years, 2 months ago

Reviewers:
Anton Muhin, podivilov1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Merge BaseGenerator into HtmlDartInterfaceGenerator. R=antonm@google.com Committed: https://code.google.com/p/dart/source/detail?r=13180

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+133 lines, -171 lines)			Patch
M	lib/html/scripts/dartdomgenerator.py	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	lib/html/scripts/dartgenerator.py	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	lib/html/scripts/systembase.py	View	1 chunk	+0 lines, -153 lines	0 comments	Download
M	lib/html/scripts/systemhtml.py	View	11 chunks	+116 lines, -12 lines	2 comments	Download
M	lib/html/scripts/systemnative.py	View	2 chunks	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm https://codereview.chromium.org/11045020/diff/1/lib/html/scripts/systemhtml.py File lib/html/scripts/systemhtml.py (right): https://codereview.chromium.org/11045020/diff/1/lib/html/scripts/systemhtml.py#newcode1094 lib/html/scripts/systemhtml.py:1094: def _DartType(self, type_name): I am slightly uneasy about ...

8 years, 2 months ago (2012-10-03 13:37:49 UTC) #2

podivilov1

8 years, 2 months ago (2012-10-03 15:57:37 UTC) #3

https://codereview.chromium.org/11045020/diff/1/lib/html/scripts/systemhtml.py
File lib/html/scripts/systemhtml.py (right):

https://codereview.chromium.org/11045020/diff/1/lib/html/scripts/systemhtml.p...
lib/html/scripts/systemhtml.py:1094: def _DartType(self, type_name):
On 2012/10/03 13:37:49, Anton Muhin wrote:
> I am slightly uneasy about duplication of this code.
> 
> It's definitely small, maybe introduce a function?

I'm somewhat reluctant to accessing private fields of arbitrary objects from a
static function. Maybe leave as is for now?

Expand Messages | Collapse Messages