Issue 11045009: Fix markdown syntax in Intl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11045009: Fix markdown syntax in Intl (Closed)

Created:
8 years, 2 months ago by Alan Knight

Modified:
8 years, 2 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix markdown syntax in Intl Committed: https://code.google.com/p/dart/source/detail?r=13153

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+89 lines, -74 lines)			Patch
M	pkg/intl/lib/date_format.dart	View	8 chunks	+87 lines, -72 lines	2 comments	Download
M	pkg/intl/lib/src/date_format_internal.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/intl/lib/src/lazy_locale_data.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lovely, these changes will be great! lgtm https://codereview.chromium.org/11045009/diff/1/pkg/intl/lib/date_format.dart File pkg/intl/lib/date_format.dart (right): https://codereview.chromium.org/11045009/diff/1/pkg/intl/lib/date_format.dart#newcode183 pkg/intl/lib/date_format.dart:183: * new ...

8 years, 2 months ago (2012-10-02 23:44:07 UTC) #2

Alan Knight

8 years, 2 months ago (2012-10-02 23:45:33 UTC) #3

https://codereview.chromium.org/11045009/diff/1/pkg/intl/lib/date_format.dart
File pkg/intl/lib/date_format.dart (right):

https://codereview.chromium.org/11045009/diff/1/pkg/intl/lib/date_format.dart...
pkg/intl/lib/date_format.dart:183: *     new DateFormat('EEE, M/d/y');
On 2012/10/02 23:44:08, Emily Fortuna wrote:
> I thought ` denoted code?
It didn't seem to. It was coming out with literal backquotes in the output.
Indenting four spaces did produce the right output.

Expand Messages | Collapse Messages